From: Denis Kenzior <denkenz@gmail.com>
Date: Tue, 16 Mar 2010 20:44:29 +0000 (-0500)
Subject: Fix: Fixup error paths in sim_op_check_cached
X-Git-Tag: 0.20~70
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=62007cd074e33e01e4c3f5336b1735a3d56d5292;p=platform%2Fupstream%2Fofono.git

Fix: Fixup error paths in sim_op_check_cached
---

diff --git a/src/sim.c b/src/sim.c
index 03d3e6e..cc258c8 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -1502,6 +1502,9 @@ static gboolean sim_op_check_cached(struct ofono_sim *sim)
 
 	path = g_strdup_printf(SIM_CACHE_PATH, imsi, sim->phase, op->id);
 
+	if (path == NULL)
+		return FALSE;
+
 	fd = TFR(open(path, O_RDONLY));
 	g_free(path);
 
@@ -1537,7 +1540,10 @@ static gboolean sim_op_check_cached(struct ofono_sim *sim)
 		goto cleanup;
 	}
 
-	buffer = g_malloc(file_length);
+	buffer = g_try_malloc(file_length);
+
+	if (buffer == NULL)
+		goto cleanup;
 
 	len = TFR(read(fd, buffer, file_length));