From: Al Viro Date: Sun, 24 Jul 2011 21:11:33 +0000 (-0400) Subject: jffs2: S_ISLNK(mode & S_IFMT) is pointless X-Git-Tag: v3.1-rc1~147^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=61effb519cbf0b2973c65070a890fabfcbf84756;p=profile%2Fivi%2Fkernel-x86-ivi.git jffs2: S_ISLNK(mode & S_IFMT) is pointless it's S_ISLNK(mode), TYVM... Signed-off-by: Al Viro --- diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c index eeead33..b81b35d 100644 --- a/fs/jffs2/fs.c +++ b/fs/jffs2/fs.c @@ -80,7 +80,7 @@ int jffs2_do_setattr (struct inode *inode, struct iattr *iattr) ALLOC_NORMAL, JFFS2_SUMMARY_INODE_SIZE); if (ret) { jffs2_free_raw_inode(ri); - if (S_ISLNK(inode->i_mode & S_IFMT)) + if (S_ISLNK(inode->i_mode)) kfree(mdata); return ret; }