From: Zhang Qilong Date: Sat, 24 Sep 2022 12:13:08 +0000 (+0800) Subject: spi: dw: Fix PM disable depth imbalance in dw_spi_bt1_probe X-Git-Tag: v6.1-rc5~19^2~26^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=618d815fc93477b1675878f3c04ff32657cc18b4;p=platform%2Fkernel%2Flinux-starfive.git spi: dw: Fix PM disable depth imbalance in dw_spi_bt1_probe The pm_runtime_enable will increase power disable depth. Thus a pairing decrement is needed on the error handling path to keep it balanced according to context. Fixes:abf00907538e2 ("spi: dw: Add Baikal-T1 SPI Controller glue driver") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20220924121310.78331-3-zhangqilong3@huawei.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-dw-bt1.c b/drivers/spi/spi-dw-bt1.c index c065534..3fb89de 100644 --- a/drivers/spi/spi-dw-bt1.c +++ b/drivers/spi/spi-dw-bt1.c @@ -293,8 +293,10 @@ static int dw_spi_bt1_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); ret = dw_spi_add_host(&pdev->dev, dws); - if (ret) + if (ret) { + pm_runtime_disable(&pdev->dev); goto err_disable_clk; + } platform_set_drvdata(pdev, dwsbt1);