From: Sudeep Holla Date: Mon, 9 Sep 2019 15:21:07 +0000 (+0100) Subject: reset: reset-scmi: add missing handle initialisation X-Git-Tag: v5.4-rc1~3^2~1^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=61423712dbb86e02af4aa5de65b9041493c92cac;p=platform%2Fkernel%2Flinux-rpi.git reset: reset-scmi: add missing handle initialisation scmi_reset_data->handle needs to be initialised at probe, so that it can be later used to access scmi reset protocol APIs using the same. Since it was tested with a module that obtained handle elsewhere, it was missed easily. Add the missing scmi_reset_data->handle initialisation to fix the issue. Fixes: c8ae9c2da1cc ("reset: Add support for resets provided by SCMI") Acked-by: Philipp Zabel Reported-by: Etienne Carriere Signed-off-by: Sudeep Holla --- diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c index c6d3c84..b46df80 100644 --- a/drivers/reset/reset-scmi.c +++ b/drivers/reset/reset-scmi.c @@ -102,6 +102,7 @@ static int scmi_reset_probe(struct scmi_device *sdev) data->rcdev.owner = THIS_MODULE; data->rcdev.of_node = np; data->rcdev.nr_resets = handle->reset_ops->num_domains_get(handle); + data->handle = handle; return devm_reset_controller_register(dev, &data->rcdev); }