From: Chuhong Yuan <hslester96@gmail.com>
Date: Thu, 28 Nov 2019 02:00:21 +0000 (+0800)
Subject: net: macb: add missed tasklet_kill
X-Git-Tag: v5.15~4998^2~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=61183b056b49e2937ff92a1424291ba36a6f6d05;p=platform%2Fkernel%2Flinux-starfive.git

net: macb: add missed tasklet_kill

This driver forgets to kill tasklet in remove.
Add the call to fix it.

Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index d5ae2e1..9c767ee 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4422,6 +4422,7 @@ static int macb_remove(struct platform_device *pdev)
 		mdiobus_free(bp->mii_bus);
 
 		unregister_netdev(dev);
+		tasklet_kill(&bp->hresp_err_tasklet);
 		pm_runtime_disable(&pdev->dev);
 		pm_runtime_dont_use_autosuspend(&pdev->dev);
 		if (!pm_runtime_suspended(&pdev->dev)) {