From: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Date: Mon, 8 Aug 2016 08:15:22 +0000 (+0900)
Subject: ecore gl module - dont check value that is already valid
X-Git-Tag: upstream/1.20.0~4882
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=60fec61c8bc6a817b317d29b8556bc5b468828bf;p=platform%2Fupstream%2Fefl.git

ecore gl module - dont check value that is already valid

make coverity happy with CID 1347410 - it's technically right that the
code assumes the im ptr is valid until then as it dereferences it
until then and then stores it under pd->image but then checks for
NULL.. it would have crashed already if it were, so rmemove the
pointless check.
---

diff --git a/src/modules/evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c b/src/modules/evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c
index 2e34d4e..e39f1f1 100644
--- a/src/modules/evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c
+++ b/src/modules/evas/engines/gl_generic/evas_ector_gl_rgbaimage_buffer.c
@@ -48,7 +48,6 @@ _evas_ector_gl_rgbaimage_buffer_evas_ector_buffer_engine_image_set(Eo *obj, Evas
    pd->evas = eo_xref(evas, obj);
    evas_cache_image_ref(&im->cache_entry);
    pd->image = im;
-   if (!pd->image) return;
 
    ector_buffer_pixels_set(obj, im->image.data, im->cache_entry.w, im->cache_entry.h, 0, (Efl_Gfx_Colorspace) im->cache_entry.space, EINA_TRUE, 0, 0, 0, 0);
 }