From: Jaehoon Chung Date: Mon, 25 Mar 2024 02:07:58 +0000 (+0900) Subject: dynamic-partitions: testlib: Fix overflow coverity issue X-Git-Tag: accepted/tizen/unified/20240325.141306~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=60ebd6d7bb4fdeb69f8c1b9f647a3c88eeb99d2b;p=platform%2Fcore%2Fsystem%2Fupgrade.git dynamic-partitions: testlib: Fix overflow coverity issue It should be overflow according to multiply number_of_parts by PART_SIZE_B. The type of number_of_parts is 'int'. To prevent incorrect operation, cast a proper type. Change-Id: I8fd44cc7622b25631f49f7df670a7a5bf435997e Signed-off-by: Jaehoon Chung --- diff --git a/src/dynamic-partitions/testlib/metadataio.cpp b/src/dynamic-partitions/testlib/metadataio.cpp index 58c7ac9..1a05dc5 100644 --- a/src/dynamic-partitions/testlib/metadataio.cpp +++ b/src/dynamic-partitions/testlib/metadataio.cpp @@ -43,7 +43,7 @@ void addPartitions(android::fs_mgr::LpMetadata &metadata, int number_of_groups, } std::unique_ptr addPartitions(int number_of_groups, int number_of_parts) { - uint64_t group_size = number_of_parts * PART_SIZE_B; + uint64_t group_size = uint64_t(number_of_parts) * PART_SIZE_B; uint64_t super_size = ALIGNMENT + number_of_groups * group_size; auto builder = android::fs_mgr::MetadataBuilder::New(super_size, METADATA_SIZE, number_of_groups, ALIGNMENT);