From: Shang XiaoJing <shangxiaojing@huawei.com>
Date: Thu, 17 Nov 2022 11:37:14 +0000 (+0800)
Subject: nfc: s3fwrn5: Fix potential memory leak in s3fwrn5_nci_send()
X-Git-Tag: v6.6.17~6137^2~40^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=60dcb5ff55e5c5da259a0dcc4c24c842de1abc9d;p=platform%2Fkernel%2Flinux-rpi.git

nfc: s3fwrn5: Fix potential memory leak in s3fwrn5_nci_send()

s3fwrn5_nci_send() won't free the skb when it failed for the check
before s3fwrn5_write(). As the result, the skb will memleak. Free the
skb when the check failed.

Fixes: c04c674fadeb ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Suggested-by: Pavel Machek <pavel@denx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/core.c
index 0270e05..aec3568 100644
--- a/drivers/nfc/s3fwrn5/core.c
+++ b/drivers/nfc/s3fwrn5/core.c
@@ -105,6 +105,7 @@ static int s3fwrn5_nci_send(struct nci_dev *ndev, struct sk_buff *skb)
 	mutex_lock(&info->mutex);
 
 	if (s3fwrn5_get_mode(info) != S3FWRN5_MODE_NCI) {
+		kfree_skb(skb);
 		mutex_unlock(&info->mutex);
 		return -EINVAL;
 	}