From: Alexander Z Lam Date: Thu, 11 Jul 2013 00:34:34 +0000 (-0700) Subject: tracing: Fix error handling to ensure instances can always be removed X-Git-Tag: accepted/tizen/common/20141203.182822~1777^2~15 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=609e85a70bcd0eedf4ec60639dbcfb1ab011e054;p=platform%2Fkernel%2Flinux-arm64.git tracing: Fix error handling to ensure instances can always be removed Remove debugfs directories for tracing instances during creation if an error occurs causing the trace_array for that instance to not be added to ftrace_trace_arrays. If the directory continues to exist after the error, it cannot be removed because the respective trace_array is not in ftrace_trace_arrays. Link: http://lkml.kernel.org/r/1373502874-1706-2-git-send-email-azl@google.com Cc: stable@vger.kernel.org # 3.10 Cc: Vaibhav Nagarnaik Cc: David Sharp Cc: Alexander Z Lam Signed-off-by: Alexander Z Lam Signed-off-by: Steven Rostedt --- diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 25b91af..7c3da7b 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -5973,8 +5973,10 @@ static int new_instance_create(const char *name) goto out_free_tr; ret = event_trace_add_tracer(tr->dir, tr); - if (ret) + if (ret) { + debugfs_remove_recursive(tr->dir); goto out_free_tr; + } init_tracer_debugfs(tr, tr->dir);