From: Rasmus Villemoes Date: Thu, 22 Jan 2015 17:01:23 +0000 (+0100) Subject: perf tests: Fix typo in sample-parsing.c X-Git-Tag: v4.14-rc1~5434^2~117^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=605a3069161dd966d6cea795133c673fb6706e52;p=platform%2Fkernel%2Flinux-rpi.git perf tests: Fix typo in sample-parsing.c It was testing the same buffer for differences: memcmp(s1->user_stack.data, s1->user_stack.data, s1->user_stack.size) I'm pretty sure this wasn't supposed to be dead code. Signed-off-by: Rasmus Villemoes Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1421946083-29863-1-git-send-email-linux@rasmusvillemoes.dk Signed-off-by: Arnaldo Carvalho de Melo --- diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c index 4908c64..30c0218 100644 --- a/tools/perf/tests/sample-parsing.c +++ b/tools/perf/tests/sample-parsing.c @@ -110,7 +110,7 @@ static bool samples_same(const struct perf_sample *s1, if (type & PERF_SAMPLE_STACK_USER) { COMP(user_stack.size); - if (memcmp(s1->user_stack.data, s1->user_stack.data, + if (memcmp(s1->user_stack.data, s2->user_stack.data, s1->user_stack.size)) { pr_debug("Samples differ at 'user_stack'\n"); return false;