From: Tim-Philipp Müller <tim@centricular.com>
Date: Mon, 10 Aug 2015 11:45:27 +0000 (+0100)
Subject: qtdemux: fix suboptimal queue iteration code
X-Git-Tag: 1.19.3~509^2~3347
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=604cc2a54812eeb46512c8073d9d01cf8087f592;p=platform%2Fupstream%2Fgstreamer.git

qtdemux: fix suboptimal queue iteration code
---

diff --git a/gst/isomp4/qtdemux.c b/gst/isomp4/qtdemux.c
index 8a40ea1..eeacca1 100644
--- a/gst/isomp4/qtdemux.c
+++ b/gst/isomp4/qtdemux.c
@@ -6980,6 +6980,8 @@ gst_qtdemux_add_stream (GstQTDemux * qtdemux,
   }
 
   if (stream->pad) {
+    GList *l;
+
     GST_DEBUG_OBJECT (qtdemux, "adding pad %s %p to qtdemux %p",
         GST_OBJECT_NAME (stream->pad), stream->pad, qtdemux);
     gst_element_add_pad (GST_ELEMENT_CAST (qtdemux), stream->pad);
@@ -6993,11 +6995,8 @@ gst_qtdemux_add_stream (GstQTDemux * qtdemux,
     stream->send_global_tags = TRUE;
     /* send upstream GST_EVENT_PROTECTION events that were received before
        this source pad was created */
-    for (int i = 0; i < qtdemux->protection_event_queue.length; ++i) {
-      GstEvent *event =
-          (GstEvent *) g_queue_peek_nth (&qtdemux->protection_event_queue, i);
-      gst_pad_push_event (stream->pad, gst_event_ref (event));
-    }
+    for (l = qtdemux->protection_event_queue.head; l != NULL; l = l->next)
+      gst_pad_push_event (stream->pad, gst_event_ref (l->data));
   }
 done:
   if (list)