From: Shinas Rasheed Date: Fri, 8 Dec 2023 05:56:46 +0000 (-0800) Subject: octeon_ep: explicitly test for firmware ready value X-Git-Tag: v6.6.17~1986 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6047060105e44c7108c715535fc92c0226995a40;p=platform%2Fkernel%2Flinux-rpi.git octeon_ep: explicitly test for firmware ready value [ Upstream commit 284f717622417cb267e344a9174f8e5698d1e3c1 ] The firmware ready value is 1, and get firmware ready status function should explicitly test for that value. The firmware ready value read will be 2 after driver load, and on unbind till firmware rewrites the firmware ready back to 0, the value seen by driver will be 2, which should be regarded as not ready. Fixes: 10c073e40469 ("octeon_ep: defer probe if firmware not ready") Signed-off-by: Shinas Rasheed Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 5b46ca4..2ee1374 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -1076,7 +1076,8 @@ static bool get_fw_ready_status(struct pci_dev *pdev) pci_read_config_byte(pdev, (pos + 8), &status); dev_info(&pdev->dev, "Firmware ready status = %u\n", status); - return status; +#define FW_STATUS_READY 1ULL + return status == FW_STATUS_READY; } return false; }