From: Lv Ruyi (CGEL ZTE) Date: Tue, 15 Mar 2022 01:12:21 +0000 (-0700) Subject: Input: mt6779-keypad - fix signedness bug X-Git-Tag: v6.1~32^2~37^2~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5fb3fb8aa22ff6e6da4018fd3ab3e30e2fdc5e53;p=platform%2Fkernel%2Flinux-starfive.git Input: mt6779-keypad - fix signedness bug The irq variable is defined as unsigned int. If the platform_get_irq() returns a negative value, data type cast may result in error. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi (CGEL ZTE) Reviewed-by: Mattijs Korpershoek Link: https://lore.kernel.org/r/20220308025054.2077162-1-lv.ruyi@zte.com.cn Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c index 5ff2325..0dbbddc 100644 --- a/drivers/input/keyboard/mt6779-keypad.c +++ b/drivers/input/keyboard/mt6779-keypad.c @@ -91,7 +91,7 @@ static void mt6779_keypad_clk_disable(void *data) static int mt6779_keypad_pdrv_probe(struct platform_device *pdev) { struct mt6779_keypad *keypad; - unsigned int irq; + int irq; u32 debounce; bool wakeup; int error;