From: Michael Braun Date: Mon, 10 Oct 2016 17:12:20 +0000 (+0200) Subject: mac80211: remove unnecessary num_mcast_sta check X-Git-Tag: v4.14-rc1~1973^2~382^2~40 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5f9994bd4a58f72a4312fb3e09c7fe2c4ca95b82;p=platform%2Fkernel%2Flinux-rpi3.git mac80211: remove unnecessary num_mcast_sta check Checking for num_mcast_sta in __ieee80211_request_smps_ap() is unnecessary as sta list will be empty in this case anyway, so the list iteration will just exit immediately. Since this isn't a "hot" code path, it doesn't really matter, and the next patch will redefine num_mcast_sta to make this check invalid. Signed-off-by: Michael Braun [change commit message] Signed-off-by: Johannes Berg --- diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index 7d01723..7de34a3 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -2477,13 +2477,6 @@ int __ieee80211_request_smps_ap(struct ieee80211_sub_if_data *sdata, smps_mode == IEEE80211_SMPS_AUTOMATIC) return 0; - /* If no associated stations, there's no need to do anything */ - if (!atomic_read(&sdata->u.ap.num_mcast_sta)) { - sdata->smps_mode = smps_mode; - ieee80211_queue_work(&sdata->local->hw, &sdata->recalc_smps); - return 0; - } - ht_dbg(sdata, "SMPS %d requested in AP mode, sending Action frame to %d stations\n", smps_mode, atomic_read(&sdata->u.ap.num_mcast_sta));