From: Heiko Stübner Date: Fri, 5 Jul 2013 12:40:53 +0000 (+0200) Subject: misc: sram: fix error path in sram_probe X-Git-Tag: accepted/tizen/common/20141203.182822~1622^2~43 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5f90b9b484938f7466e25cd5506e86ebf9dbcd17;p=platform%2Fkernel%2Flinux-arm64.git misc: sram: fix error path in sram_probe The pool is created thru devm_gen_pool_create, so the call to gen_pool_destroy is not necessary. Instead the sram-clock must be turned off again if it exists. Signed-off-by: Heiko Stuebner Tested-by: Ulrich Prinz Acked-by: Philipp Zabel Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c index d87cc91..afe66571 100644 --- a/drivers/misc/sram.c +++ b/drivers/misc/sram.c @@ -68,7 +68,8 @@ static int sram_probe(struct platform_device *pdev) ret = gen_pool_add_virt(sram->pool, (unsigned long)virt_base, res->start, size, -1); if (ret < 0) { - gen_pool_destroy(sram->pool); + if (sram->clk) + clk_disable_unprepare(sram->clk); return ret; }