From: Andrei Coardos <aboutphysycs@gmail.com>
Date: Fri, 28 Jul 2023 17:59:14 +0000 (+0300)
Subject: gpio: palmas: remove unnecessary call to platform_set_drvdata()
X-Git-Tag: v6.6.7~2081^2~49
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5f57665a217e82ca5e5362829f64b526d2f245c5;p=platform%2Fkernel%2Flinux-starfive.git

gpio: palmas: remove unnecessary call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---

diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c
index 6140e87..28dba70 100644
--- a/drivers/gpio/gpio-palmas.c
+++ b/drivers/gpio/gpio-palmas.c
@@ -183,7 +183,6 @@ static int palmas_gpio_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	platform_set_drvdata(pdev, palmas_gpio);
 	return ret;
 }