From: Tong Tiangen Date: Fri, 11 Jun 2021 01:40:55 +0000 (+0800) Subject: usb: isp1760: Fix meaningless check in isp1763_run() X-Git-Tag: v5.15~788^2~49 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5f4dee73a4bc25a7781a5406b49439bc640981c2;p=platform%2Fkernel%2Flinux-starfive.git usb: isp1760: Fix meaningless check in isp1763_run() Remove attribution to retval before check, which make it completely meaningless, and does't check what it was supposed: the return value of the timed function to set up configuration flag. Fixes: 60d789f3bfbb ("usb: isp1760: add support for isp1763") Tested-by: Rui Miguel Silva Reviewed-by: Rui Miguel Silva Signed-off-by: Tong Tiangen Link: https://lore.kernel.org/r/20210611014055.68551-1-tongtiangen@huawei.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c index 016a54e..27168b4 100644 --- a/drivers/usb/isp1760/isp1760-hcd.c +++ b/drivers/usb/isp1760/isp1760-hcd.c @@ -1648,7 +1648,6 @@ static int isp1763_run(struct usb_hcd *hcd) down_write(&ehci_cf_port_reset_rwsem); retval = isp1760_hcd_set_and_wait(hcd, FLAG_CF, 250 * 1000); up_write(&ehci_cf_port_reset_rwsem); - retval = 0; if (retval) return retval;