From: Yunmi Ha Date: Thu, 19 Aug 2021 08:42:41 +0000 (+0900) Subject: Add checking NULL for strdup X-Git-Tag: submit/tizen/20210820.083850^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5f35f5aa73c24a23ea27a2de52781136a5584dde;p=platform%2Fcore%2Fapi%2Fsensor.git Add checking NULL for strdup Change-Id: I42b437d06970045fc8d3af8c919c54d903a4db5e Signed-off-by: Yunmi Ha --- diff --git a/src/sensor.cpp b/src/sensor.cpp index 63bda6f..d63290c 100644 --- a/src/sensor.cpp +++ b/src/sensor.cpp @@ -813,10 +813,15 @@ int sensor_listener_flush(sensor_listener_h listener) int sensor_get_uri(sensor_h sensor, char **uri) { + const char *ret_url; + if (!sensor || !uri) return SENSOR_ERROR_INVALID_PARAMETER; - *uri = strdup(sensord_get_uri(sensor)); + if ((ret_url = sensord_get_uri(sensor)) == NULL) + return SENSOR_ERROR_OPERATION_FAILED; + + *uri = strdup(ret_url); return SENSOR_ERROR_NONE; } @@ -825,10 +830,15 @@ int sensor_get_name(sensor_h sensor, char** name) { _D("called sensor_get_name"); + const char *ret_name; + if (!sensor || !name) return SENSOR_ERROR_INVALID_PARAMETER; - *name = strdup(sensord_get_name(sensor)); + if ((ret_name = sensord_get_name(sensor)) == NULL) + return SENSOR_ERROR_OPERATION_FAILED; + + *name = strdup(ret_name); _D("success sensor_get_vendor : [%s]", *name); @@ -839,10 +849,15 @@ int sensor_get_vendor(sensor_h sensor, char** vendor) { _D("called sensor_get_vendor"); + const char *ret_vendor; + if (!sensor || !vendor) return SENSOR_ERROR_INVALID_PARAMETER; - *vendor = strdup(sensord_get_vendor(sensor)); + if ((ret_vendor = sensord_get_vendor(sensor)) == NULL) + return SENSOR_ERROR_OPERATION_FAILED; + + *vendor = strdup(ret_vendor); _D("success sensor_vendor : [%s]", *vendor);