From: salimfadhley Date: Sat, 12 Oct 2013 16:55:29 +0000 (+0100) Subject: many pep8 violations fixed X-Git-Tag: v0.2.23~85 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5ef35afa03226ffeaf480451d2f557c117ddea55;p=tools%2Fpython-jenkinsapi.git many pep8 violations fixed --- diff --git a/jenkinsapi/build.py b/jenkinsapi/build.py index f859224..343b4ac 100644 --- a/jenkinsapi/build.py +++ b/jenkinsapi/build.py @@ -192,7 +192,8 @@ class Build(JenkinsBase): """ # <<<<<<< HEAD # downstream_jobs_names = self.job.get_downstream_job_names() -# fingerprint_data = self.get_data("%s?depth=2&tree=fingerprint[usage[name]]" % self.python_api_url(self.baseurl)) +# fingerprint_data = self.get_data("%s?depth=2&tree=fingerprint[usage[name]]" \ +# % self.python_api_url(self.baseurl)) # try: # fingerprints = fingerprint_data['fingerprint'][0] # return [ @@ -205,7 +206,7 @@ class Build(JenkinsBase): downstream_names = [] try: fingerprints = self._data["fingerprint"] - for fingerprint in fingerprints : + for fingerprint in fingerprints: for job_usage in fingerprint['usage']: if job_usage['name'] in downstream_job_names: downstream_names.append(job_usage['name']) @@ -235,7 +236,7 @@ class Build(JenkinsBase): downstream_builds = [] try: fingerprints = self._data["fingerprint"] - for fingerprint in fingerprints : + for fingerprint in fingerprints: for job_usage in fingerprint['usage']: if job_usage['name'] in downstream_job_names: job = self.get_jenkins_obj().get_job(job_usage['name']) diff --git a/jenkinsapi/jenkins.py b/jenkinsapi/jenkins.py index 3b6503a..13c4e20 100644 --- a/jenkinsapi/jenkins.py +++ b/jenkinsapi/jenkins.py @@ -92,8 +92,8 @@ class Jenkins(JenkinsBase): Fetch all the build-names on this Jenkins server. """ for info in self._data["jobs"]: - yield info["name"],\ - Job(info["url"], info["name"], jenkins_obj=self) + yield info["name"], \ + Job(info["url"], info["name"], jenkins_obj=self) def get_jobs_info(self): """ diff --git a/jenkinsapi/jobs.py b/jenkinsapi/jobs.py index fbef338..0801450 100644 --- a/jenkinsapi/jobs.py +++ b/jenkinsapi/jobs.py @@ -79,9 +79,11 @@ class Jobs(object): params = {'name': job_name} if isinstance(config, unicode): config = str(config) - self.jenkins.requester.\ - post_xml_and_confirm_status(self.jenkins.get_create_url(), - data=config, params=params) + self.jenkins.requester.post_xml_and_confirm_status( + self.jenkins.get_create_url(), + data=config, + params=params + ) self.jenkins.poll() if job_name not in self: raise JenkinsAPIException('Cannot create job %s' % job_name) diff --git a/jenkinsapi/utils/requester.py b/jenkinsapi/utils/requester.py index 36a0719..0460b99 100644 --- a/jenkinsapi/utils/requester.py +++ b/jenkinsapi/utils/requester.py @@ -40,7 +40,6 @@ class Requester(object): self.password = password self.ssl_verify = ssl_verify - def get_request_dict(self, params=None, data=None, files=None, headers=None): requestKwargs = {} if self.username: @@ -76,11 +75,11 @@ class Requester(object): url_split = urlparse.urlsplit(url) url = urlparse.urlunsplit( [ - self.base_scheme, - url_split.netloc, - url_split.path, - url_split.query, - url_split.fragment + self.base_scheme, + url_split.netloc, + url_split.path, + url_split.query, + url_split.fragment ] ) return url