From: Eric W. Biederman Date: Thu, 26 Jan 2012 14:02:55 +0000 (+0000) Subject: netns: Fail conspicously if someone uses net_generic at an inappropriate time. X-Git-Tag: upstream/snapshot3+hdmi~8225^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5ee4433efe99b9f39f6eff5052a177bbcfe72cea;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git netns: Fail conspicously if someone uses net_generic at an inappropriate time. By definition net_generic should never be called when it can return NULL. Fail conspicously with a BUG_ON to make it clear when people mess up that a NULL return should never happen. Recently there was a bug in the CAIF subsystem where it was registered with register_pernet_device instead of register_pernet_subsys. It was erroneously concluded that net_generic could validly return NULL and that net_assign_generic was buggy (when it was just inefficient). Hopefully this BUG_ON will prevent people to coming to similar erroneous conclusions in the futrue. Signed-off-by: Eric W. Biederman Tested-by: Sasha Levin Signed-off-by: David S. Miller --- diff --git a/include/net/netns/generic.h b/include/net/netns/generic.h index 3419bf5..d55f434 100644 --- a/include/net/netns/generic.h +++ b/include/net/netns/generic.h @@ -41,6 +41,7 @@ static inline void *net_generic(const struct net *net, int id) ptr = ng->ptr[id - 1]; rcu_read_unlock(); + BUG_ON(!ptr); return ptr; } #endif