From: Thomas Hartmann <Thomas.Hartmann@digia.com>
Date: Mon, 8 Oct 2012 08:34:09 +0000 (+0200)
Subject: crash fix in designersupport
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5ed77ed046873f9df293753b05a4c5eee0b1f61d;p=profile%2Fivi%2Fqtdeclarative.git

crash fix in designersupport

Unless result is an insert iterator, qCopy()
assumes that all iterators in the range
[result + (finish - start)] are dereferenceable.
This is not the case for an empty list.

Using foreach instead.

Change-Id: I2212a88e9b462ae2220ba5aeb43c662592cec57f
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
---

diff --git a/src/quick/designer/designersupport.cpp b/src/quick/designer/designersupport.cpp
index 5584a24..c06e8f0 100644
--- a/src/quick/designer/designersupport.cpp
+++ b/src/quick/designer/designersupport.cpp
@@ -363,7 +363,10 @@ QList<QObject*> DesignerSupport::statesForItem(QQuickItem *item)
 {
     QList<QObject*> objectList;
     QList<QQuickState *> stateList = QQuickItemPrivate::get(item)->_states()->states();
-    qCopy(stateList.begin(), stateList.end(), objectList.begin());
+
+    objectList.reserve(stateList.size());
+    foreach (QQuickState* state, stateList)
+        objectList.append(state);
 
     return objectList;
 }