From: Devendra Naga Date: Wed, 11 Jul 2012 09:50:32 +0000 (+0800) Subject: leds/leds-s3c24xx: use devm_gpio_request X-Git-Tag: upstream/snapshot3+hdmi~6948^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5ecf6e40bbb8649b8418c8038a2af1faefbc56e4;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git leds/leds-s3c24xx: use devm_gpio_request why? because if the led_classdev_register fails we wont do gpio free because using devm_ functions, there is no need for error paths Signed-off-by: Devendra Naga Signed-off-by: Bryan Wu --- diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c index e120640..942f0ea 100644 --- a/drivers/leds/leds-s3c24xx.c +++ b/drivers/leds/leds-s3c24xx.c @@ -65,7 +65,6 @@ static int s3c24xx_led_remove(struct platform_device *dev) struct s3c24xx_gpio_led *led = pdev_to_gpio(dev); led_classdev_unregister(&led->cdev); - gpio_free(led->pdata->gpio); return 0; } @@ -92,7 +91,7 @@ static int s3c24xx_led_probe(struct platform_device *dev) led->pdata = pdata; - ret = gpio_request(pdata->gpio, "S3C24XX_LED"); + ret = devm_gpio_request(&dev->dev, pdata->gpio, "S3C24XX_LED"); if (ret < 0) return ret;