From: seungha son <seungha.son@samsung.com>
Date: Thu, 28 Mar 2024 03:29:04 +0000 (+0900)
Subject: [Edge] Add checking return value
X-Git-Tag: accepted/tizen/unified/20240402.061259~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5ecbf89561e1415f1b57349fd7f4e213498de3bf;p=platform%2Fupstream%2Fnnstreamer-edge.git

[Edge] Add checking return value

 In _nns_edge_transfer_data(), there is no checking return value.
 It is difficult to check when a problem occurs during the data transmission process,
 so check return values and add logs when problems occur.

Signed-off-by: seungha son <seungha.son@samsung.com>
---

diff --git a/src/libnnstreamer-edge/nnstreamer-edge-internal.c b/src/libnnstreamer-edge/nnstreamer-edge-internal.c
index d8da1a4..c1b892b 100644
--- a/src/libnnstreamer-edge/nnstreamer-edge-internal.c
+++ b/src/libnnstreamer-edge/nnstreamer-edge-internal.c
@@ -486,11 +486,25 @@ _nns_edge_transfer_data (nns_edge_conn_s * conn, nns_edge_data_h data_h,
 
   _nns_edge_cmd_init (&cmd, _NNS_EDGE_CMD_TRANSFER_DATA, client_id);
 
-  nns_edge_data_get_count (data_h, &cmd.info.num);
-  for (i = 0; i < cmd.info.num; i++)
-    nns_edge_data_get (data_h, i, &cmd.mem[i], &cmd.info.mem_size[i]);
+  ret = nns_edge_data_get_count (data_h, &cmd.info.num);
+  if (ret != NNS_EDGE_ERROR_NONE) {
+    nns_edge_loge ("Failed to get data count");
+    return ret;
+  }
 
-  nns_edge_data_serialize_meta (data_h, &cmd.meta, &cmd.info.meta_size);
+  for (i = 0; i < cmd.info.num; i++) {
+    ret = nns_edge_data_get (data_h, i, &cmd.mem[i], &cmd.info.mem_size[i]);
+    if (ret != NNS_EDGE_ERROR_NONE) {
+      nns_edge_loge ("Failed to get data");
+      return ret;
+    }
+  }
+
+  ret = nns_edge_data_serialize_meta (data_h, &cmd.meta, &cmd.info.meta_size);
+  if (ret != NNS_EDGE_ERROR_NONE) {
+    nns_edge_loge ("Failed to serialize meta");
+    return ret;
+  }
 
   ret = _nns_edge_cmd_send (conn, &cmd);
   SAFE_FREE (cmd.meta);