From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 24 Jul 2018 17:11:28 +0000 (+0200)
Subject: fbdev: omapfb: off by one in omapfb_register_client()
X-Git-Tag: v4.19~108^2~33
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5ec1ec35b2979b59d0b33381e7c9aac17e159d16;p=platform%2Fkernel%2Flinux-rpi.git

fbdev: omapfb: off by one in omapfb_register_client()

The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the
> should be >= or we are one element beyond the end of the array.

Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Imre Deak <imre.deak@solidboot.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---

diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index 585f39e..1c75f48 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -958,7 +958,7 @@ int omapfb_register_client(struct omapfb_notifier_block *omapfb_nb,
 {
 	int r;
 
-	if ((unsigned)omapfb_nb->plane_idx > OMAPFB_PLANE_NUM)
+	if ((unsigned)omapfb_nb->plane_idx >= OMAPFB_PLANE_NUM)
 		return -EINVAL;
 
 	if (!notifier_inited) {