From: Giuseppe Cavallaro Date: Mon, 29 Nov 2010 02:10:53 +0000 (-0800) Subject: stmmac: fix stmmac_resume removing not yet used shutdown flag X-Git-Tag: v3.0~2504^2~415 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5e9559689735f760f3a1fb9b2aafeb4d8efbf8f5;p=platform%2Fkernel%2Flinux-amlogic.git stmmac: fix stmmac_resume removing not yet used shutdown flag The commit to convert to use the dev_pm_ops struct introduces a bug. The shutdown flag is not yet used because the hibernation on memory is done by using the freeze callback. Thanks to Vlad for having reported it. Reported-by: Vlad Lungu Signed-off-by: Giuseppe Cavallaro Signed-off-by: David S. Miller --- diff --git a/drivers/net/stmmac/stmmac_main.c b/drivers/net/stmmac/stmmac_main.c index f1dbc18..730a6fd 100644 --- a/drivers/net/stmmac/stmmac_main.c +++ b/drivers/net/stmmac/stmmac_main.c @@ -1846,13 +1846,6 @@ static int stmmac_resume(struct device *dev) if (!netif_running(ndev)) return 0; - if (priv->shutdown) { - /* Re-open the interface and re-init the MAC/DMA - and the rings (i.e. on hibernation stage) */ - stmmac_open(dev); - return 0; - } - spin_lock(&priv->lock); /* Power Down bit, into the PM register, is cleared