From: Miroslav Benes Date: Tue, 27 Oct 2020 14:03:36 +0000 (+0100) Subject: module: set MODULE_STATE_GOING state when a module fails to load X-Git-Tag: accepted/tizen/unified/20230118.172025~8230^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5e8ed280dab9eeabc1ba0b2db5dbe9fe6debb6b5;p=platform%2Fkernel%2Flinux-rpi.git module: set MODULE_STATE_GOING state when a module fails to load If a module fails to load due to an error in prepare_coming_module(), the following error handling in load_module() runs with MODULE_STATE_COMING in module's state. Fix it by correctly setting MODULE_STATE_GOING under "bug_cleanup" label. Signed-off-by: Miroslav Benes Signed-off-by: Jessica Yu --- diff --git a/kernel/module.c b/kernel/module.c index a4fa44a..b342350 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3991,6 +3991,7 @@ static int load_module(struct load_info *info, const char __user *uargs, MODULE_STATE_GOING, mod); klp_module_going(mod); bug_cleanup: + mod->state = MODULE_STATE_GOING; /* module_bug_cleanup needs module_mutex protection */ mutex_lock(&module_mutex); module_bug_cleanup(mod);