From: Fedor Indutny <fedor.indutny@gmail.com>
Date: Tue, 27 Mar 2012 18:37:54 +0000 (+0700)
Subject: debugger: use v8 api to wait for a connection
X-Git-Tag: v0.7.7~31
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5e8c2b0768f32051457cb6cb7e068722e4348fa4;p=platform%2Fupstream%2Fnodejs.git

debugger: use v8 api to wait for a connection

Use v8::Debug::EnableAgent(_, _, true) to wait for incoming
debugger-client connection before emitting any break (or other) events.

This commit should fix test/simple/test-debugger-repl faults.
---

diff --git a/src/node.cc b/src/node.cc
index 08862d4..907bd41 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -2390,15 +2390,9 @@ static void EnableDebug(bool wait_connect) {
   node_isolate->Enter();
 
   // Start the debug thread and it's associated TCP server on port 5858.
-  bool r = v8::Debug::EnableAgent("node " NODE_VERSION, debug_port);
-
-  if (wait_connect) {
-    // Set up an empty handler so v8 will not continue until a debugger
-    // attaches. This is the same behavior as Debug::EnableAgent(_,_,true)
-    // except we don't break at the beginning of the script.
-    // see Debugger::StartAgent in debug.cc of v8/src
-    v8::Debug::SetMessageHandler2(node::DebugBreakMessageHandler);
-  }
+  bool r = v8::Debug::EnableAgent("node " NODE_VERSION,
+                                  debug_port,
+                                  wait_connect);
 
   // Crappy check that everything went well. FIXME
   assert(r);