From: Jaechul Lee <jcsing.lee@samsung.com>
Date: Thu, 12 Oct 2023 06:31:04 +0000 (+0900)
Subject: tizenaudio-sink2/source2: Return 0 when closing devices fails
X-Git-Tag: accepted/tizen/unified/20231025.093254~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5e575703bc92f6dfd743f64c4c1e4771ab2c4b48;p=platform%2Fcore%2Fmultimedia%2Fpulseaudio-modules-tizen.git

tizenaudio-sink2/source2: Return 0 when closing devices fails

In case of USB devices, closing PCM function could be failed because the
snd node already disappear.

AUDIO_HAL(P 1276, T 3928): tizen-audio-impl-pcm.c: _pcm_close(156) > Error closing PCM handle : No such device
AUDIO_HAL(P 1276, T 3928): tizen-audio-glue.c: audio_close(131) > Failed to close device
PULSEAUDIO(P 1276, T 3928): hal-interface.c: pa_hal_interface_pcm_close(349) > hal_audio_pcm_close error:0x80001005
PULSEAUDIO(P 1276, T 3928): tizenaudio-source2.c: suspend(147) > Error closing PCM device. rtpoll will be stopped anyway
PULSEAUDIO(P 1276, T 3928): tizenaudio-source2.c: suspend(156) > Device suspended...
PULSEAUDIO(P 1276, T 3928): hal-interface.c: pa_hal_interface_pcm_available(360) > Assertion 'pcm_h' failed at src/hal-interface.c:360, function pa_hal_interface_pcm_av
PULSEAUDIO(P 1276, T 1276): source.c: source_set_state(491) > Assertion 'resuming' failed at ../src/pulsecore/source.c:491, function source_set_state(). Aborting.

[Version] 15.0.59
[Issue Type] Bug Fix

Change-Id: I2be4ae86c090a994e6e9227720ea020b6fea25d9
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
---

diff --git a/packaging/pulseaudio-modules-tizen.spec b/packaging/pulseaudio-modules-tizen.spec
index d0b011f..8df8f9b 100644
--- a/packaging/pulseaudio-modules-tizen.spec
+++ b/packaging/pulseaudio-modules-tizen.spec
@@ -2,7 +2,7 @@
 
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          15.0.58
+Version:          15.0.59
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+
diff --git a/src/tizenaudio-sink2.c b/src/tizenaudio-sink2.c
index 8a45e91..3e39382 100644
--- a/src/tizenaudio-sink2.c
+++ b/src/tizenaudio-sink2.c
@@ -153,7 +153,7 @@ static int suspend(struct userdata *u) {
 
     pa_log_info("Device suspended...");
 
-    return ret;
+    return 0;
 }
 
 /* Called from IO context */
diff --git a/src/tizenaudio-source2.c b/src/tizenaudio-source2.c
index 771f174..1b15829 100644
--- a/src/tizenaudio-source2.c
+++ b/src/tizenaudio-source2.c
@@ -155,7 +155,7 @@ static int suspend(struct userdata *u) {
 
     pa_log_info("Device suspended...");
 
-    return ret;
+    return 0;
 }
 
 /* Called from IO context */