From: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun, 26 Aug 2012 22:43:26 +0000 (+0100)
Subject: eds: Remove unnecessary locking
X-Git-Tag: FOLKS_0_7_4_1~42
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5df5c3f4cacf16c67c4b1493a3008b418ae98b2c;p=platform%2Fupstream%2Ffolks.git

eds: Remove unnecessary locking

It didn’t achieve anything.
---

diff --git a/backends/eds/lib/edsf-persona-store.vala b/backends/eds/lib/edsf-persona-store.vala
index 05cdc17..cce55f7 100644
--- a/backends/eds/lib/edsf-persona-store.vala
+++ b/backends/eds/lib/edsf-persona-store.vala
@@ -2099,17 +2099,15 @@ public class Edsf.PersonaStore : Folks.PersonaStore
   private void _contacts_added_cb (GLib.List<E.Contact> contacts)
     {
       var added_personas = new HashSet<Persona> ();
-      lock (this._personas)
+
+      foreach (E.Contact c in contacts)
         {
-          foreach (E.Contact c in contacts)
+          var iid = Edsf.Persona.build_iid_from_contact (this.id, c);
+          if (this._personas.has_key (iid) == false)
             {
-              var iid = Edsf.Persona.build_iid_from_contact (this.id, c);
-              if (this._personas.has_key (iid) == false)
-                {
-                  var persona = new Persona (this, c);
-                  this._personas.set (persona.iid, persona);
-                  added_personas.add (persona);
-                }
+              var persona = new Persona (this, c);
+              this._personas.set (persona.iid, persona);
+              added_personas.add (persona);
             }
         }