From: Zach Brown Date: Tue, 3 Oct 2006 08:16:08 +0000 (-0700) Subject: [PATCH] pr_debug: tipar: repair nonexistant pr_debug argument use X-Git-Tag: 2.1b_release~31096 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5df0a29d9c2239c28b5864037b51ac3d747439a9;p=platform%2Fkernel%2Fkernel-mfld-blackbay.git [PATCH] pr_debug: tipar: repair nonexistant pr_debug argument use tipar: repair nonexistant pr_debug argument use I guessed what the pr_debug meant by 'data'. Signed-off-by: Zach Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/char/tipar.c b/drivers/char/tipar.c index d30dc09..9df0ca1 100644 --- a/drivers/char/tipar.c +++ b/drivers/char/tipar.c @@ -224,14 +224,16 @@ probe_ti_parallel(int minor) { int i; int seq[] = { 0x00, 0x20, 0x10, 0x30 }; + int data; for (i = 3; i >= 0; i--) { outbyte(3, minor); outbyte(i, minor); udelay(delay); + data = inbyte(minor) & 0x30; pr_debug("tipar: Probing -> %i: 0x%02x 0x%02x\n", i, - data & 0x30, seq[i]); - if ((inbyte(minor) & 0x30) != seq[i]) { + data, seq[i]); + if (data != seq[i]) { outbyte(3, minor); return -1; }