From: mtklein <mtklein@chromium.org>
Date: Fri, 29 Jul 2016 16:10:31 +0000 (-0700)
Subject: GN: components as static library instead of source set
X-Git-Tag: submit/tizen/20180928.044319~116^2~499
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5db44aa2aa4a3a1b9ce1fe7e22c54c8d9b61f51d;p=platform%2Fupstream%2FlibSkiaSharp.git

GN: components as static library instead of source set

This also puts the .a in the top-level of the ouptut directory, just
like we do for .so files.  It's less required than for .sos, but it
does make it easier to find the .a.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197633002

Review-Url: https://codereview.chromium.org/2197633002
---

diff --git a/gn/BUILD.gn b/gn/BUILD.gn
index e514bc3be4..5789aef48b 100644
--- a/gn/BUILD.gn
+++ b/gn/BUILD.gn
@@ -88,7 +88,7 @@ toolchain("gcc_like") {
   tool("alink") {
     command = "rm -f {{output}} && $ar rcs {{output}} {{inputs}}"
     outputs = [
-      "{{target_out_dir}}/{{target_output_name}}{{output_extension}}",
+      "{{root_out_dir}}/{{target_output_name}}{{output_extension}}",
     ]
     default_output_extension = ".a"
     output_prefix = "lib"
diff --git a/gn/BUILDCONFIG.gn b/gn/BUILDCONFIG.gn
index 31056bda5f..681b15b83b 100644
--- a/gn/BUILDCONFIG.gn
+++ b/gn/BUILDCONFIG.gn
@@ -27,9 +27,9 @@ is_win = current_os == "win"
 
 is_posix = !is_win
 
-# A component is either a source_set or a shared_library.
+# A component is either a static or a shared library.
 template("component") {
-  _component_mode = "source_set"
+  _component_mode = "static_library"
   if (is_component_build) {
     _component_mode = "shared_library"
   }