From: Mark Kettenis Date: Sun, 14 Dec 2003 10:59:08 +0000 (+0000) Subject: * i386-tdep.c (i386_analyze_frame_setup): Add missing encodings X-Git-Tag: cagney_bigcore-20040122-branchpoint~478 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5daa5b4ecc8e4dd8532538fedcdaeeec25244c15;p=external%2Fbinutils.git * i386-tdep.c (i386_analyze_frame_setup): Add missing encodings for `subl' and `xorl' instructions. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 179bffb..c164aa1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2003-12-14 Mark Kettenis + + * i386-tdep.c (i386_analyze_frame_setup): Add missing encodings + for `subl' and `xorl' instructions. + 2003-12-13 Jim Blandy * dwarf2read.c (dwarf2_add_member_fn, read_structure_scope): diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 973fa63..4ee9fa4 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -508,9 +508,13 @@ i386_analyze_frame_setup (CORE_ADDR pc, CORE_ADDR current_pc, subl %edx, %edx subl %eax, %eax + Because of the symmetry, there are actually two ways to + encode these instructions; with opcode bytes 0x29 and 0x2b + for `subl' and opcode bytes 0x31 and 0x33 for `xorl'. + Make sure we only skip these instructions if we later see the `movl %esp, %ebp' that actually sets up the frame. */ - while (op == 0x29 || op == 0x31) + while (op == 0x29 || op == 0x2b || op == 0x31 || op == 0x33) { op = read_memory_unsigned_integer (pc + skip + 2, 1); switch (op)