From: Dan Carpenter Date: Thu, 9 Aug 2012 06:57:30 +0000 (+0300) Subject: wireless: at76c50x: signedness bug in at76_dfu_get_state() X-Git-Tag: accepted/tizen/common/20141203.182822~3858^2~22^2~29 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5d774b74ef7d0428a3e45c9bb5b3a0915d2240cb;p=platform%2Fkernel%2Flinux-arm64.git wireless: at76c50x: signedness bug in at76_dfu_get_state() This return holds the number of bytes transfered (1 byte) or a negative error code. The type should be int instead of u8. Signed-off-by: Dan Carpenter Acked-by: Pavel Roskin Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c index efc162e..88b8d64 100644 --- a/drivers/net/wireless/at76c50x-usb.c +++ b/drivers/net/wireless/at76c50x-usb.c @@ -342,7 +342,7 @@ static int at76_dfu_get_status(struct usb_device *udev, return ret; } -static u8 at76_dfu_get_state(struct usb_device *udev, u8 *state) +static int at76_dfu_get_state(struct usb_device *udev, u8 *state) { int ret;