From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 30 May 2013 07:50:46 +0000 (+0300)
Subject: [SCSI] fnic: potential dead lock in fnic_is_abts_pending()
X-Git-Tag: v3.11-rc1~88^2~19
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5d65f91896197bd047f97ed8e7792b06de491eac;p=platform%2Fupstream%2Fkernel-adaptation-pc.git

[SCSI] fnic: potential dead lock in fnic_is_abts_pending()

There is an unlock missing if the == FNIC_IOREQ_ABTS_PENDING is
false.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hiral Patel <hiralpat@cisco.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
---

diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index be99e75..a97e6e5 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -2432,11 +2432,9 @@ int fnic_is_abts_pending(struct fnic *fnic, struct scsi_cmnd *lr_sc)
 			      "Found IO in %s on lun\n",
 			      fnic_ioreq_state_to_str(CMD_STATE(sc)));
 
-		if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING) {
-			spin_unlock_irqrestore(io_lock, flags);
+		if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING)
 			ret = 1;
-			continue;
-		}
+		spin_unlock_irqrestore(io_lock, flags);
 	}
 
 	return ret;