From: Christian Engelmayer Date: Wed, 7 May 2014 19:31:20 +0000 (+0200) Subject: staging: rtl8188eu: fix potential leak in rtw_wx_set_enc_ext() X-Git-Tag: v4.14-rc1~7083^2~39^2~417 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5d57f1e8f6699653f2e5b7c9dfad6b0dd0c8dcd3;p=platform%2Fkernel%2Flinux-rpi.git staging: rtl8188eu: fix potential leak in rtw_wx_set_enc_ext() Function rtw_wx_set_enc_ext() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077712. Signed-off-by: Christian Engelmayer Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c index 45b47e2..1bd476d 100644 --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c @@ -2097,7 +2097,8 @@ static int rtw_wx_set_enc_ext(struct net_device *dev, alg_name = "CCMP"; break; default: - return -1; + ret = -1; + goto exit; } strncpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); @@ -2124,6 +2125,7 @@ static int rtw_wx_set_enc_ext(struct net_device *dev, ret = wpa_set_encryption(dev, param, param_len); +exit: kfree(param); return ret; }