From: Dan Carpenter <error27@gmail.com>
Date: Thu, 9 Apr 2009 14:09:45 +0000 (+0000)
Subject: ERR_PTR() dereference in net/rds/iw.c
X-Git-Tag: v2.6.31-rc1~14^2~751
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5d57eeb52ae71a03c8e083a9b0a818a9b63ca440;p=platform%2Fkernel%2Flinux-3.10.git

ERR_PTR() dereference in net/rds/iw.c

rdma_create_id() returns ERR_PTR() not null.

Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/rds/iw.c b/net/rds/iw.c
index b732efb..d16e1cb 100644
--- a/net/rds/iw.c
+++ b/net/rds/iw.c
@@ -233,8 +233,8 @@ static int rds_iw_laddr_check(__be32 addr)
 	 * IB and iWARP capable NICs.
 	 */
 	cm_id = rdma_create_id(NULL, NULL, RDMA_PS_TCP);
-	if (!cm_id)
-		return -EADDRNOTAVAIL;
+	if (IS_ERR(cm_id))
+		return PTR_ERR(cm_id);
 
 	memset(&sin, 0, sizeof(sin));
 	sin.sin_family = AF_INET;