From: Sebastian Dröge <sebastian@centricular.com>
Date: Fri, 17 Mar 2023 15:13:39 +0000 (+0200)
Subject: matroskademux: Make gst_byte_reader_get_data() usage less confusing
X-Git-Tag: 1.22.7~404
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5d0d42fb9546b317f6e2184d85eca6d2460e287e;p=platform%2Fupstream%2Fgstreamer.git

matroskademux: Make gst_byte_reader_get_data() usage less confusing

This is effectively the same behaviour but retrieving 0 bytes of data is
confusing to read.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4221>
---

diff --git a/subprojects/gst-plugins-good/gst/matroska/matroska-read-common.c b/subprojects/gst-plugins-good/gst/matroska/matroska-read-common.c
index 6fadbba..0e9d0b6 100644
--- a/subprojects/gst-plugins-good/gst/matroska/matroska-read-common.c
+++ b/subprojects/gst-plugins-good/gst/matroska/matroska-read-common.c
@@ -592,8 +592,9 @@ gst_matroska_parse_protection_meta (gpointer * data_out, gsize * size_out,
     gst_structure_set (info_protect, "subsample_count", G_TYPE_UINT, 0, NULL);
   }
 
-  gst_byte_reader_get_data (&reader, 0, (const guint8 **) data_out);
   *size_out = gst_byte_reader_get_remaining (&reader);
+  gst_byte_reader_get_data (&reader, *size_out, (const guint8 **) data_out);
+
   return TRUE;
 
 release_err: