From: Konstantin Ritt Date: Mon, 9 Jul 2012 14:08:54 +0000 (+0300) Subject: Fix the UCS-2 surrogates handling in Q*FontEndine*::stringToCmap() X-Git-Tag: v5.0.0-beta1~930 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5cf93c435228af9527f42aea32585cb156d78826;p=profile%2Fivi%2Fqtbase.git Fix the UCS-2 surrogates handling in Q*FontEndine*::stringToCmap() by making sure QGlyphLayout's numGlyphs member is properly initialized if the string-to-glyphs lookup was successful (tip: a surrogate pair produces a single glyph index). Change-Id: I01953f3b6281d79e1a214bfab0424e796d94769a Reviewed-by: Konstantin Ritt --- diff --git a/src/platformsupport/fontdatabases/mac/qfontengine_coretext.mm b/src/platformsupport/fontdatabases/mac/qfontengine_coretext.mm index b07d59d..92eaebb 100644 --- a/src/platformsupport/fontdatabases/mac/qfontengine_coretext.mm +++ b/src/platformsupport/fontdatabases/mac/qfontengine_coretext.mm @@ -211,6 +211,8 @@ bool QCoreTextFontEngine::stringToCMap(const QChar *str, int len, QGlyphLayout * } *nglyphs = glyph_pos; + glyphs->numGlyphs = glyph_pos; + if (flags & GlyphIndicesOnly) return true; diff --git a/src/plugins/platforms/windows/qwindowsfontengine.cpp b/src/plugins/platforms/windows/qwindowsfontengine.cpp index b3bba55..d7f48e5 100644 --- a/src/plugins/platforms/windows/qwindowsfontengine.cpp +++ b/src/plugins/platforms/windows/qwindowsfontengine.cpp @@ -363,6 +363,7 @@ bool QWindowsFontEngine::stringToCMap(const QChar *str, int len, QGlyphLayout *g return false; } + glyphs->numGlyphs = *nglyphs; *nglyphs = getGlyphIndexes(str, len, glyphs, flags & RightToLeft); if (!(flags & GlyphIndicesOnly)) diff --git a/src/plugins/platforms/windows/qwindowsfontenginedirectwrite.cpp b/src/plugins/platforms/windows/qwindowsfontenginedirectwrite.cpp index 1f7c4f4..3490ebf 100644 --- a/src/plugins/platforms/windows/qwindowsfontenginedirectwrite.cpp +++ b/src/plugins/platforms/windows/qwindowsfontenginedirectwrite.cpp @@ -330,6 +330,7 @@ bool QWindowsFontEngineDirectWrite::stringToCMap(const QChar *str, int len, QGly glyphs->glyphs[i] = glyphIndices[i]; *nglyphs = len; + glyphs->numGlyphs = len; if (!(flags & GlyphIndicesOnly)) recalcAdvances(glyphs, 0);