From: Wei Yongjun Date: Tue, 28 Apr 2020 23:09:53 +0000 (-0700) Subject: Input: synaptics-rmi4 - fix error return code in rmi_driver_probe() X-Git-Tag: v5.10.7~1015^2~35 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5caab2da63207d6d631007f592f5219459e3454d;p=platform%2Fkernel%2Flinux-rpi.git Input: synaptics-rmi4 - fix error return code in rmi_driver_probe() Fix to return a negative error code from the input_register_device() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Link: https://lore.kernel.org/r/20200428134948.78343-1-weiyongjun1@huawei.com Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index c18e1a2..258d5fe 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c @@ -1210,7 +1210,8 @@ static int rmi_driver_probe(struct device *dev) if (data->input) { rmi_driver_set_input_name(rmi_dev, data->input); if (!rmi_dev->xport->input) { - if (input_register_device(data->input)) { + retval = input_register_device(data->input); + if (retval) { dev_err(dev, "%s: Failed to register input device.\n", __func__); goto err_destroy_functions;