From: Russell King Date: Wed, 15 Jul 2015 17:11:25 +0000 (+0100) Subject: drm/armada: move the update of dplane->ctrl0 out of spinlock X-Git-Tag: v4.14-rc1~3993^2~21^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5c8752c6506abf29950d32366f826899dc87dde7;p=platform%2Fkernel%2Flinux-rpi.git drm/armada: move the update of dplane->ctrl0 out of spinlock It is not necessary to write dplane->ctrl0 under the CRTC spinlock, as this is only accessed under process context where the DRM locks will protect us instead. Signed-off-by: Russell King --- diff --git a/drivers/gpu/drm/armada/armada_overlay.c b/drivers/gpu/drm/armada/armada_overlay.c index 9686d79..e7e020d4 100644 --- a/drivers/gpu/drm/armada/armada_overlay.c +++ b/drivers/gpu/drm/armada/armada_overlay.c @@ -275,9 +275,10 @@ static int armada_ovl_plane_disable(struct drm_plane *plane) spin_lock_irq(&dcrtc->irq_lock); armada_drm_vbl_event_remove(dcrtc, &dplane->vbl.update); - dplane->ctrl0 = 0; spin_unlock_irq(&dcrtc->irq_lock); + dplane->ctrl0 = 0; + armada_drm_crtc_plane_disable(dcrtc, plane); fb = xchg(&dplane->old_fb, NULL);