From: Uwe Kleine-König Date: Thu, 26 Nov 2020 16:59:49 +0000 (+0100) Subject: ALSA: ppc: drop if block with always false condition X-Git-Tag: v5.15~1735^2~88 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5c7797022fe9a95a4417c75fa59a1a2bfdc5a3be;p=platform%2Fkernel%2Flinux-starfive.git ALSA: ppc: drop if block with always false condition The remove callback is only called for devices that were probed successfully before. As the matching probe function cannot complete without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to check this here. Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven Tested-by: Geoff Levand Link: https://lore.kernel.org/r/20201126165950.2554997-1-u.kleine-koenig@pengutronix.de Signed-off-by: Takashi Iwai --- diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c index 58bb49f..6ab796a 100644 --- a/sound/ppc/snd_ps3.c +++ b/sound/ppc/snd_ps3.c @@ -1053,8 +1053,6 @@ static int snd_ps3_driver_remove(struct ps3_system_bus_device *dev) { int ret; pr_info("%s:start id=%d\n", __func__, dev->match_id); - if (dev->match_id != PS3_MATCH_ID_SOUND) - return -ENXIO; /* * ctl and preallocate buffer will be freed in