From: Per Bothner Date: Wed, 25 Mar 1992 23:07:16 +0000 (+0000) Subject: * command.c, main.c (various places): Use ctype.h macros X-Git-Tag: gdb-4_18~22147 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5c71cf23f98882e7a91e14b0c8f1f54045f5de29;p=platform%2Fupstream%2Fbinutils.git * command.c, main.c (various places): Use ctype.h macros (such as isupper(x)), instead of hard-wiring in ASCII-isms (such as (x >= 'A' && x <= 'Z')). (There are still more of these in other files.) * main.c (defined_command): Lower-case the user's new command before entering it. Needed because command lookup is case-insensitive (and also lower-cases). (Based on Metin's earlier patch.) --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8855139..5b60ed1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,14 @@ +Wed Mar 25 14:55:48 1992 Per Bothner (bothner@cygnus.com) + + * command.c, main.c (various places): Use ctype.h macros + (such as isupper(x)), instead of hard-wiring in ASCII-isms + (such as (x >= 'A' && x <= 'Z')). + (There are still more of these in other files.) + * main.c (defined_command): Lower-case the user's + new command before entering it. Needed because + command lookup is case-insensitive (and also lower-cases). + (Based on Metin's earlier patch.) + Tue Mar 24 23:27:01 1992 K. Richard Pixley (rich@cygnus.com) * config/irix4.mh: new file. diff --git a/gdb/command.c b/gdb/command.c index 4eed2a0..f39600e 100644 --- a/gdb/command.c +++ b/gdb/command.c @@ -535,7 +535,7 @@ lookup_cmd_1 (text, clist, result_list, ignore_help_classes) for (tmp = 0; tmp < len; tmp++) { char x = (*text)[tmp]; - command[tmp] = (x >= 'A' && x <= 'Z') ? x - 'A' + 'a' : x; + command[tmp] = isupper(x) ? tolower(x) : x; } command[len] = '\0'; @@ -784,10 +784,7 @@ lookup_cmd (line, list, cmdtype, allow_unknown) /* Find end of command name. */ p = *line; - while (*p == '-' - || (*p >= 'a' && *p <= 'z') - || (*p >= 'A' && *p <= 'Z') - || (*p >= '0' && *p <= '9')) + while (*p == '-' || isalnum(*p)) p++; /* Look up the command name. @@ -812,8 +809,8 @@ lookup_cmd (line, list, cmdtype, allow_unknown) for (cmd_len = 0; cmd_len < p - *line; cmd_len++) { char x = (*line)[cmd_len]; - if (x >= 'A' && x <= 'Z') - processed_cmd[cmd_len] = x - 'A' + 'a'; + if (isupper(x)) + processed_cmd[cmd_len] = tolower(x); else processed_cmd[cmd_len] = x; }