From: Dan Carpenter Date: Fri, 9 Jul 2010 23:51:54 +0000 (+0000) Subject: 9p: strlen() doesn't count the terminator X-Git-Tag: v2.6.36-rc1~571^2~259 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5c4bfa17f3ec46becec4b23d12323f7605ebd696;p=platform%2Fkernel%2Flinux-3.10.git 9p: strlen() doesn't count the terminator This is an off by one bug because strlen() doesn't count the NULL terminator. We strcpy() addr into a fixed length array of size UNIX_PATH_MAX later on. The addr variable is the name of the device being mounted. CC: stable@kernel.org Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 98ce9bc..c85109d 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c @@ -948,7 +948,7 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args) csocket = NULL; - if (strlen(addr) > UNIX_PATH_MAX) { + if (strlen(addr) >= UNIX_PATH_MAX) { P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n", addr); return -ENAMETOOLONG;