From: Tom de Vries <tdevries@suse.de>
Date: Tue, 2 Oct 2018 19:47:54 +0000 (+0200)
Subject: [gdb/python] Fix cpychecker error in pspy_solib_name
X-Git-Tag: users/ARM/embedded-binutils-master-2018q4~524
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5c4481cc9bf9dfec3c35aaf5d95b08542ab8970b;p=external%2Fbinutils.git

[gdb/python] Fix cpychecker error in pspy_solib_name

When using cpychecker, we run into:
...
gdb/python/py-progspace.c: \
  In function ‘PyObject* pspy_solib_name(PyObject*, PyObject*)’:
gdb/python/py-progspace.c:370:25: error: Mismatching type in call to \
  PyArg_ParseTuple with format code "K" [-Werror]
   if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc))
  argument 3 ("&pc") had type
    "gdb_py_longest *" (pointing to 64 bits)
  but was expecting
    "long long unsigned int *" (pointing to 64 bits)
  for format code "K"
...

Fix this fixing the type of the variable.

Build and reg-tested on x86_64-linux.

2018-10-05  Tom de Vries  <tdevries@suse.de>

	* python/py-progspace.c (pspy_solib_name): Fix type mismatch in
	PyArg_ParseTuple call.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 47f879f..126deb7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2018-10-05  Tom de Vries  <tdevries@suse.de>
 
+	* python/py-progspace.c (pspy_solib_name): Fix type mismatch in
+	PyArg_ParseTuple call.
+
+2018-10-05  Tom de Vries  <tdevries@suse.de>
+
 	* python/py-record-btrace.c (recpy_bt_goto): Fix type mismatch in
 	PyArg_ParseTuple call.
 
diff --git a/gdb/python/py-progspace.c b/gdb/python/py-progspace.c
index 1e16b84..6395d5b 100644
--- a/gdb/python/py-progspace.c
+++ b/gdb/python/py-progspace.c
@@ -362,7 +362,7 @@ static PyObject *
 pspy_solib_name (PyObject *o, PyObject *args)
 {
   char *soname;
-  gdb_py_longest pc;
+  gdb_py_ulongest pc;
   pspace_object *self = (pspace_object *) o;
 
   PSPY_REQUIRE_VALID (self);