From: Alexander Kanevskiy Date: Tue, 3 Jun 2014 10:35:08 +0000 (+0300) Subject: Quote group names in the URLs. X-Git-Tag: submit/devel/20190730.075403~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5c14cc4c72df7549f96722d33a85add9f21da990;p=services%2Fgerritrest.git Quote group names in the URLs. --- diff --git a/gerritrest/GerritREST.py b/gerritrest/GerritREST.py index 9e2d2e8..e2f335c 100644 --- a/gerritrest/GerritREST.py +++ b/gerritrest/GerritREST.py @@ -324,7 +324,7 @@ class GerritREST(object): if owner: info['owner_id'] = owner return self._do_json_call( - "a/groups/%s" % group, + "a/groups/%s" % self.quote_id(group), method='PUT', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info)) @@ -335,7 +335,7 @@ class GerritREST(object): """ if not group: return None - return self._do_json_call("a/groups/%s/detail" % group) + return self._do_json_call("a/groups/%s/detail" % self.quote_id(group)) def get_group_name(self, group): @@ -344,7 +344,7 @@ class GerritREST(object): """ if not group: return None - return self._do_json_call("a/groups/%s/name" % group) + return self._do_json_call("a/groups/%s/name" % self.quote_id(group)) def set_group_name(self, group, new_name): """ @@ -359,7 +359,7 @@ class GerritREST(object): return None info = {'name': new_name} return self._do_json_call( - "a/groups/%s" % group, + "a/groups/%s" % self.quote_id(group), method='PUT', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info)) @@ -370,7 +370,7 @@ class GerritREST(object): """ if not group: return None - return self._do_json_call("a/groups/%s/description" % group) + return self._do_json_call("a/groups/%s/description" % self.quote_id(group)) def set_group_description(self, group, new_description): """ @@ -385,7 +385,7 @@ class GerritREST(object): return None info = {'description': new_description} return self._do_json_call( - "a/groups/%s/description" % group, + "a/groups/%s/description" % self.quote_id(group), method='PUT', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info)) @@ -396,7 +396,7 @@ class GerritREST(object): """ if not group: return None - return self._do_json_call("a/groups/%s/description" % group, method='DELETE') + return self._do_json_call("a/groups/%s/description" % self.quote_id(group), method='DELETE') def get_group_options(self, group): """ @@ -404,7 +404,7 @@ class GerritREST(object): """ if not group: return None - return self._do_json_call("a/groups/%s/options" % group) + return self._do_json_call("a/groups/%s/options" % self.quote_id(group)) def set_group_options(self, group, visible_to_all=None): """ @@ -419,7 +419,7 @@ class GerritREST(object): return None info = {'visible_to_all': visible_to_all} return self._do_json_call( - "a/groups/%s/options" % group, + "a/groups/%s/options" % self.quote_id(group), method='PUT', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info)) @@ -430,7 +430,7 @@ class GerritREST(object): """ if not group: return None - return self._do_json_call("a/groups/%s/owner" % group) + return self._do_json_call("a/groups/%s/owner" % self.quote_id(group)) def set_group_owner(self, group, new_owner): """ @@ -446,7 +446,7 @@ class GerritREST(object): return None info = {'owner': new_owner} return self._do_json_call( - "a/groups/%s/owner" % group, + "a/groups/%s/owner" % self.quote_id(group), method='PUT', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info)) @@ -457,7 +457,7 @@ class GerritREST(object): """ if not group or not member: return None - return self._do_json_call("a/groups/%s/member/%s" % (group, member)) + return self._do_json_call("a/groups/%s/member/%s" % (self.quote_id(group), member)) def add_group_member(self, group, member): """ @@ -465,7 +465,7 @@ class GerritREST(object): """ if not group or not member: return None - return self._do_json_call("a/groups/%s/members/%s" % (group, member), method='PUT', data="") + return self._do_json_call("a/groups/%s/members/%s" % (self.quote_id(group), member), method='PUT', data="") def delete_group_member(self, group, member): """ @@ -473,7 +473,7 @@ class GerritREST(object): """ if not group or not member: return None - return self._do_json_call("a/groups/%s/members/%s" % (group, member), method='DELETE') + return self._do_json_call("a/groups/%s/members/%s" % (self.quote_id(group), member), method='DELETE') def get_group_members(self, group, recursive=None): """ @@ -483,7 +483,7 @@ class GerritREST(object): if not group: return None options = "?recursive" if recursive else "" - return self._do_json_call("a/groups/%s/members/%s" % (group, options)) + return self._do_json_call("a/groups/%s/members/%s" % (self.quote_id(group), options)) def add_group_members(self, group, members): """ @@ -507,7 +507,7 @@ class GerritREST(object): return None info = {'members': members} return self._do_json_call( - "a/groups/%s/members.add" % group, + "a/groups/%s/members.add" % self.quote_id(group), method='POST', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info)) @@ -532,7 +532,7 @@ class GerritREST(object): return None info = {'members': members} return self._do_json_call( - "a/groups/%s/members.delete" % group, + "a/groups/%s/members.delete" % self.quote_id(group), method='POST', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info)) @@ -543,7 +543,7 @@ class GerritREST(object): """ if not group or not included_group: return None - return self._do_json_call("a/groups/%s/groups/%s" % (group, included_group)) + return self._do_json_call("a/groups/%s/groups/%s" % (self.quote_id(group), included_group)) def add_group_group(self, group, included_group): """ @@ -551,7 +551,7 @@ class GerritREST(object): """ if not group or not included_group: return None - return self._do_json_call("a/groups/%s/groups/%s" % (group, included_group), method='PUT', data="") + return self._do_json_call("a/groups/%s/groups/%s" % (self.quote_id(group), included_group), method='PUT', data="") def delete_group_group(self, group, included_group): """ @@ -559,7 +559,7 @@ class GerritREST(object): """ if not group or not included_group: return None - return self._do_json_call("a/groups/%s/groups/%s" % (group, included_group), method='DELETE') + return self._do_json_call("a/groups/%s/groups/%s" % (self.quote_id(group), included_group), method='DELETE') def get_group_groups(self, group): """ @@ -567,7 +567,7 @@ class GerritREST(object): """ if not group: return None - return self._do_json_call("a/groups/%s/groups" % group) + return self._do_json_call("a/groups/%s/groups" % self.quote_id(group)) def add_group_groups(self, group, included_groups): """ @@ -592,7 +592,7 @@ class GerritREST(object): return None info = {'groups': included_groups} return self._do_json_call( - "a/groups/%s/groups.add" % group, + "a/groups/%s/groups.add" % self.quote_id(group), method='POST', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info)) @@ -618,7 +618,7 @@ class GerritREST(object): return None info = {'groups': included_groups} return self._do_json_call( - "a/groups/%s/groups.delete" % group, + "a/groups/%s/groups.delete" % self.quote_id(group), method='POST', headers={'Content-Type': 'application/json;charset=UTF-8'}, data=json.dumps(info))