From: Johan Hovold Date: Wed, 7 Apr 2021 10:39:04 +0000 (+0200) Subject: USB: serial: f81534: fix TIOCGSERIAL implementation X-Git-Tag: v5.15~1313^2~20^2~55 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5c1426df9bb4363ed06bfbb35aaa7cf6076e9953;p=platform%2Fkernel%2Flinux-starfive.git USB: serial: f81534: fix TIOCGSERIAL implementation TIOCSSERIAL is a horrid, underspecified, legacy interface which for most serial devices is only useful for setting the close_delay and closing_wait parameters. The port parameter is used to set the I/O port and does not make any sense to use for USB serial devices. The close_delay and closing_wait parameters returned by TIOCGSERIAL are specified in centiseconds. The driver does not yet support changing these, but let's report back the default values actually used (0.5 and 30 seconds, respectively). Fixes: aac1fc386fa1 ("USB: serial: add Fintek F81232 usb to serial driver") Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold --- diff --git a/drivers/usb/serial/f81534.c b/drivers/usb/serial/f81534.c index a763b36..c9f90d4 100644 --- a/drivers/usb/serial/f81534.c +++ b/drivers/usb/serial/f81534.c @@ -1149,9 +1149,11 @@ static int f81534_get_serial_info(struct tty_struct *tty, port_priv = usb_get_serial_port_data(port); ss->type = PORT_16550A; - ss->port = port->port_number; ss->line = port->minor; ss->baud_base = port_priv->baud_base; + ss->close_delay = 50; + ss->closing_wait = 3000; + return 0; }