From: Sriram Date: Thu, 12 Nov 2009 01:55:42 +0000 (+0000) Subject: TI Davinci EMAC : Fix Console Hang when bringing the interface down X-Git-Tag: v2.6.32-rc8~10^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5bfa2a17f2b79eb6a63c5d47ce89d5798bba086a;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git TI Davinci EMAC : Fix Console Hang when bringing the interface down In the NAPI poll function(emac_poll), check for netif_running() is unnecassary. In addition to associated runtime overhead, it also results in a continuous softirq loop when the interface is brought down under heavy traffic(tested wit Traffic Generator). Once the interface is disabled, the poll function always returns zero(with the check for netif_running) and napi_complete() would never get called resulting in softirq loop. Signed-off-by: Sriramakrishnan Acked-by: Chaithrika U S Signed-off-by: David S. Miller --- diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c index 3179521..db63803 100644 --- a/drivers/net/davinci_emac.c +++ b/drivers/net/davinci_emac.c @@ -2140,9 +2140,6 @@ static int emac_poll(struct napi_struct *napi, int budget) u32 status = 0; u32 num_pkts = 0; - if (!netif_running(ndev)) - return 0; - /* Check interrupt vectors and call packet processing */ status = emac_read(EMAC_MACINVECTOR);