From: Tim-Philipp Müller <tim@centricular.com>
Date: Tue, 14 Jul 2020 11:11:57 +0000 (+0100)
Subject: buffer: fix meta sequence number fallback on rpi
X-Git-Tag: 1.19.3~756
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5bd81abdb113cbc17877d63ebdf8b903315b70c7;p=platform%2Fupstream%2Fgstreamer.git

buffer: fix meta sequence number fallback on rpi

The global seqnum variable wasn't actually increased in
the fallback code path, leading to all buffers getting
a seqnum of 0. Which also made the unit test fail.

This affects platforms/toolchains that don't have
64-bit atomic ops such as when compiling for armv7 rpi.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/565>
---

diff --git a/gst/gstbuffer.c b/gst/gstbuffer.c
index d0b6ee7..62a4d3e 100644
--- a/gst/gstbuffer.c
+++ b/gst/gstbuffer.c
@@ -192,7 +192,7 @@ gst_atomic_int64_inc (volatile gint64 * atomic)
   gint64 ret;
 
   G_LOCK (meta_seq);
-  ret = *atomic++;
+  ret = (*atomic)++;
   G_UNLOCK (meta_seq);
 
   return ret;