From: Lee Jones Date: Tue, 10 Sep 2013 12:49:00 +0000 (+0100) Subject: iio: sensors-core: st: Clean-up error handling in st_sensors_read_info_raw() X-Git-Tag: v3.13-rc1~170^2~694^2~67 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5bb8e72d5de375c855ce5ec9b818c7836feeb301;p=kernel%2Fkernel-generic.git iio: sensors-core: st: Clean-up error handling in st_sensors_read_info_raw() Saving a few lines of code. Signed-off-by: Lee Jones Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c index eb261a5..793136a 100644 --- a/drivers/iio/common/st_sensors/st_sensors_core.c +++ b/drivers/iio/common/st_sensors/st_sensors_core.c @@ -352,28 +352,25 @@ int st_sensors_read_info_raw(struct iio_dev *indio_dev, mutex_lock(&indio_dev->mlock); if (indio_dev->currentmode == INDIO_BUFFER_TRIGGERED) { err = -EBUSY; - goto read_error; + goto out; } else { err = st_sensors_set_enable(indio_dev, true); if (err < 0) - goto read_error; + goto out; msleep((sdata->sensor->bootime * 1000) / sdata->odr); err = st_sensors_read_axis_data(indio_dev, ch, val); if (err < 0) - goto read_error; + goto out; *val = *val >> ch->scan_type.shift; err = st_sensors_set_enable(indio_dev, false); } +out: mutex_unlock(&indio_dev->mlock); return err; - -read_error: - mutex_unlock(&indio_dev->mlock); - return err; } EXPORT_SYMBOL(st_sensors_read_info_raw);