From: Greg Kroah-Hartman Date: Thu, 2 Feb 2023 15:12:14 +0000 (+0100) Subject: time/debug: Fix memory leak with using debugfs_lookup() X-Git-Tag: v6.6.17~5530^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5b268d8abaec6cbd4bd70d062e769098d96670aa;p=platform%2Fkernel%2Flinux-rpi.git time/debug: Fix memory leak with using debugfs_lookup() When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Signed-off-by: Greg Kroah-Hartman Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20230202151214.2306822-1-gregkh@linuxfoundation.org --- diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c index 13b11eb62685..20d5df631570 100644 --- a/kernel/time/test_udelay.c +++ b/kernel/time/test_udelay.c @@ -149,7 +149,7 @@ module_init(udelay_test_init); static void __exit udelay_test_exit(void) { mutex_lock(&udelay_test_lock); - debugfs_remove(debugfs_lookup(DEBUGFS_FILENAME, NULL)); + debugfs_lookup_and_remove(DEBUGFS_FILENAME, NULL); mutex_unlock(&udelay_test_lock); }